Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use json_query to avoid index #26

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat: use json_query to avoid index #26

merged 1 commit into from
Feb 23, 2024
+13 −3

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Feb 20, 2024

Fixes #19

Signed-off-by: Boris Glimcher [email protected]

@glimchb glimchb requested a review from Gal-Zaidman February 20, 2024 20:22
@glimchb glimchb marked this pull request as ready for review February 20, 2024 20:22
@glimchb glimchb requested a review from a team as a code owner February 20, 2024 20:22
@glimchb
Copy link
Member Author

glimchb commented Feb 20, 2024

@sachin-apa and @jcastanos2 please review

@glimchb glimchb force-pushed the main branch 4 times, most recently from 30db692 to f8a0d7a Compare February 21, 2024 19:30
@glimchb glimchb requested a review from sachin-apa February 22, 2024 20:32
@glimchb glimchb merged commit f51c70a into opiproject:main Feb 23, 2024
36 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-apa sachin-apa sachin-apa approved these changes

@Gal-Zaidman Gal-Zaidman Awaiting requested review from Gal-Zaidman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fw_inventory_after.redfish_facts.firmware.entries[0].Version : use name instead of [0]
2 participants
@glimchb @sachin-apa